Attention is currently required from: arehbein. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30602 )
Change subject: WIP: vty: Add check against sensible default value for Ny1 ...................................................................... Patch Set 9: (2 comments) File tests/nanobts_omlattr/nanobts_omlattr_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2035): https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/5fbc1f07_4f09a9cb PS9, Line 127: static unsigned long const T3105_TESTVAL = 13; Move const after static - use 'static const unsigned long' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2035): https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/a9063cba_116bdb99 PS9, Line 130: static unsigned long const NY1_TESTVAL = (GSM_T3124_MAX + GSM_NY1_REQ_DELTA)/T3105_TESTVAL + 1; Move const after static - use 'static const unsigned long' -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If3f96a6bd4f9ae32b6421de43c1c5a5d64482089 Gerrit-Change-Number: 30602 Gerrit-PatchSet: 9 Gerrit-Owner: arehbein <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: arehbein <[email protected]> Gerrit-Comment-Date: Sat, 17 Dec 2022 15:48:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
