Attention is currently required from: arehbein.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/30602 )

Change subject: WIP: vty: Add check against sensible default value for Ny1
......................................................................


Patch Set 9:

(1 comment)

File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/5906b388_e4e27da8
PS5, Line 839: struct gsm_lchan *gl
> it's the initials of `gsm_lchan`.

Ah, I see. Fine then.

> Do you mean I should put `struct gsm_lchang const *` instead

const usually goes first in our code, so 'const struct gsm_lchan *gl' please.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30602
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If3f96a6bd4f9ae32b6421de43c1c5a5d64482089
Gerrit-Change-Number: 30602
Gerrit-PatchSet: 9
Gerrit-Owner: arehbein <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: arehbein <[email protected]>
Gerrit-Comment-Date: Sun, 18 Dec 2022 20:17:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to