Attention is currently required from: falconia.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/32183 )

Change subject: codec: add SID classification functions per GSM 06.31 & 06.81
......................................................................


Patch Set 1:

(1 comment)

File include/osmocom/codec/codec.h:

https://gerrit.osmocom.org/c/libosmocore/+/32183/comment/674a1e71_55885cad
PS1, Line 85: etsi_sid_class
I know it's not strictly followed here in this file, but generally it's a good 
idea to prepend `osmo_` prefix to all new symbols, including enums and their 
items.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32183
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie91a52c6f04689082d8004311517d8ce0c544916
Gerrit-Change-Number: 32183
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: falconia <[email protected]>
Gerrit-Comment-Date: Mon, 03 Apr 2023 13:29:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to