Attention is currently required from: falconia, pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32183 )
Change subject: codec: add SID classification functions per GSM 06.31 & 06.81 ...................................................................... Patch Set 2: (1 comment) File include/osmocom/codec/codec.h: https://gerrit.osmocom.org/c/libosmocore/+/32183/comment/a26858fb_0ef8d164 PS1, Line 85: etsi_sid_class > > @pespin - then how come none of the protocol constant definitions in > > <osmocom/gsm/protocol/gsm_XX_ […] pespin is correct in that they predate our naming conventions. In fact, they likely even predate libosmocore. Originally in 2008 we had all of the code in openbsc.git, and then we simply copied it to libosmocore.git when we needed them on the OsmocomBB side, without thinking much about it. meanwhile we do have naming rules (which should also be documented in the wiki). For a few #defines in some gsm/protocol/foo.h file I don't care too much about it (almost no source file will include them), but in terms of symbol naming of public API functions polluting the global namespace it is a concern. The lack of a proper hierarchical namespace is one of the sad historic parts of C... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie91a52c6f04689082d8004311517d8ce0c544916 Gerrit-Change-Number: 32183 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: falconia <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 04 Apr 2023 20:11:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
