Attention is currently required from: fixeria. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32183 )
Change subject: codec: add SID classification functions per GSM 06.31 & 06.81 ...................................................................... Patch Set 1: (1 comment) File include/osmocom/codec/codec.h: https://gerrit.osmocom.org/c/libosmocore/+/32183/comment/31596d60_61d95a77 PS1, Line 85: etsi_sid_class > I know it's not strictly followed here in this file, but generally it's a > good idea to prepend `osmo […] Here I used etsi_ and ETSI_ naming prefixes for the enum and its items, as opposed to osmo_ and OSMO_, to denote the fact that these constants are rigidly defined by ETSI rather than us. To my perhaps naive intuitive mind, if something is named osmo_xxx, then the implication is that the "thing" is Osmo-defined and hence future Osmocom developers are free to change and extend the thing being defined - but the constants in the present case *cannot* be changed by us, they appear exactly with these numeric values in external interfaces such as TRAU-UL frame bits C13 & C14 and a_dd[0] bits [4:3] in TI DSPs. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie91a52c6f04689082d8004311517d8ce0c544916 Gerrit-Change-Number: 32183 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 03 Apr 2023 15:14:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
