Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32075 )
Change subject: gsm_objclass2mo(): Change signature/set NACK cause ...................................................................... Patch Set 6: (2 comments) File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/32075/comment/0b74251c_e7ede57b PS6, Line 544: mo = gsm_objclass2mo(bts, foh->obj_class, &foh->obj_inst, NULL); > you could also pass a enum cause here Done https://gerrit.osmocom.org/c/osmo-bts/+/32075/comment/9d896332_70994038 PS6, Line 547: return oml_fom_ack_nack(msg, NM_NACK_OBJINST_UNKN); > and use it here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I37e6b23ed95260a8188910cf9754faffcba519c5 Gerrit-Change-Number: 32075 Gerrit-PatchSet: 6 Gerrit-Owner: arehbein <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 20 Apr 2023 23:25:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
