Attention is currently required from: arehbein, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32075 )
Change subject: gsm_objclass2mo(): Change signature/set NACK cause ...................................................................... Patch Set 7: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/32075/comment/265b3284_9a58eb8d PS3, Line 11: Change dependency can be removed if we adapt the function line length... File include/osmo-bts/oml.h: https://gerrit.osmocom.org/c/osmo-bts/+/32075/comment/ce907572_fd1336ce PS7, Line 80: stru not really the kind of coding style we use in osmocom, except for osmo-e1d which was written by tnt? But if you look at any of the other prototypes here in this file above and below, do you see line breaks done this way? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I37e6b23ed95260a8188910cf9754faffcba519c5 Gerrit-Change-Number: 32075 Gerrit-PatchSet: 7 Gerrit-Owner: arehbein <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: arehbein <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Sat, 22 Apr 2023 01:43:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
