Attention is currently required from: arehbein, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32075 )
Change subject: gsm_objclass2mo(): Change signature/set NACK cause ...................................................................... Patch Set 8: (2 comments) File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/32075/comment/4169c6e8_4fe98223 PS8, Line 1107: return oml_fom_ack_nack(msg, NM_NACK_OBJINST_UNKN); > you are missing passing "c" here instead of fixed NM_NACK_OBJINST_UNKN. NACK https://gerrit.osmocom.org/c/osmo-bts/+/32075/comment/cbec9d04_341146e9 PS8, Line 1153: return oml_fom_ack_nack(msg, NM_NACK_OBJINST_UNKN); > same, missing passing "c". NACK -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I37e6b23ed95260a8188910cf9754faffcba519c5 Gerrit-Change-Number: 32075 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: arehbein <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Sat, 29 Apr 2023 07:54:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
