Attention is currently required from: lynxis lazus.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/32511 )

Change subject: hlr: use talloc for memory allocation in 
osmo_gsup_create_insert_subscriber_data_msg
......................................................................


Patch Set 3:

(2 comments)

Patchset:

PS3:
Can you point exactly where's the problem? afaict all the buffers being used 
are of known max size there?


File src/gsup_server.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/32511/comment/b5902c30_a883e440
PS3, Line 455:                                          void *talloc_ctx)
why not using the "struct osmo_gsup_message *gsup"  as a talloc_ctx?



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32511
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I00b5c2dfadcf6e0740e93b4c3292d2654d22e80c
Gerrit-Change-Number: 32511
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Wed, 26 Apr 2023 18:23:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to