Attention is currently required from: laforge, lynxis lazus, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32511 )
Change subject: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subscriber_data_msg ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File include/osmocom/hlr/gsup_server.h: https://gerrit.osmocom.org/c/osmo-hlr/+/32511/comment/b8773d67_d23434e3 PS3, Line 71: osmo_gsup_create_insert_subscriber_data_msg > The header won't be installed and can't be used by other projects Ah, indeed. There exists `libosmo-gsup-client`, but not `libosmo-gsup-server`. Still I find it wrong that the symbol names here start with `osmo_`. Anyways, not related to this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I00b5c2dfadcf6e0740e93b4c3292d2654d22e80c Gerrit-Change-Number: 32511 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: msuraev <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Tue, 02 May 2023 17:56:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]> Gerrit-MessageType: comment
