Attention is currently required from: laforge, fixeria, pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32511 )
Change subject: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subscriber_data_msg ...................................................................... Patch Set 3: (5 comments) File include/osmocom/hlr/gsup_server.h: https://gerrit.osmocom.org/c/osmo-hlr/+/32511/comment/ab91db8c_01bc229b PS3, Line 71: osmo_gsup_create_insert_subscriber_data_msg > Looks like it is, although only osmo-hlr seem to be using it. I did `. […] No. The gsup_server.h isn't installed and part if the noinst_HEADERS. https://gerrit.osmocom.org/c/osmo-hlr/+/32511/comment/d66512bd_a2225fce PS3, Line 71: osmo_gsup_create_insert_subscriber_data_msg > Looks like it is, although only osmo-hlr seem to be using it. I did `. […] The header won't be installed and can't be used by other projects File src/hlr.c: https://gerrit.osmocom.org/c/osmo-hlr/+/32511/comment/bb13803c_9b020539 PS3, Line 133: sub_upd_ctx > Let's better use `OTC_SELECT` and avoid `goto`s. […] Ack File src/lu_fsm.c: https://gerrit.osmocom.org/c/osmo-hlr/+/32511/comment/809e0a53_98e3daf0 PS3, Line 249: lu_isr_ctx > I suggest simply using `OTC_SELECT` here. Done https://gerrit.osmocom.org/c/osmo-hlr/+/32511/comment/38dd4251_be83ae36 PS3, Line 251: return > memleak! Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I00b5c2dfadcf6e0740e93b4c3292d2654d22e80c Gerrit-Change-Number: 32511 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: msuraev <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 02 May 2023 15:06:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
