Patch Set 4: (1 comment)
Hi @dexter and Harald, > I have moved at least the bit offsets to libosmocore now. > See #5385 for that. Great. Thanks! > The probelm I see is that since it runs on the BTS it uses > the RTP bit ordering, but you probably need the GSM bit ordering. In OsmocomBB I do use the same gsm0503_tch_(fr|hr)_(en|de)code() like OsmoBTS scheduler does. They all have an undocumented parameter named 'net_order'. Probably, this is exactly what we are talking about. > Probably it makes sense if you just take the patch from osmo-bsc and > add a parameter for the table. If that works for you and the original > unit-test still passes I could re-test on osmo-bts-trx. I will try to find this change, thanks for a tip! Moreover, if you have limited time, I would take care about this change. > AFAIK OsmocomBB also does the re-ordering to RTP as it uses the MNCC > interface towards external MNCC handlers, and I think the > bit-ordering/format of the TCH messages there is identical to RTP. You probably talking about this? http://git.osmocom.org/osmocom-bb/tree/src/host/layer23/src/common/l1ctl.c#n802 http://git.osmocom.org/osmocom-bb/tree/src/host/layer23/src/common/l1ctl.c#n856 I think the L1CTL implementation is not the best place for doing bit reordering, so I've moved this to the firmware in my branch. https://gerrit.osmocom.org/#/c/5214/4/tests/meas/meas_test.c File tests/meas/meas_test.c: Line 10: #include <osmo-bts/ecu_fr.h> Is this file related to the change anyhow? I think such clean up should be done separately. And do we really need the 'ecu_fr.h' here? -- To view, visit https://gerrit.osmocom.org/5214 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae9e69a9578ae305bca42f834694af96a29084e6 Gerrit-PatchSet: 4 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
