Attention is currently required from: falconia.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/32961 )

Change subject: gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 
payloads
......................................................................


Patch Set 1:

(2 comments)

File src/coding/gsm0503_coding.c:

https://gerrit.osmocom.org/c/libosmocore/+/32961/comment/40923ceb_8a4aa902
PS1, Line 1591:         for (i = 0; i < 112; i++)
iiuc here we are removing 1 byte with this change.


https://gerrit.osmocom.org/c/libosmocore/+/32961/comment/17449589_901d5c26
PS1, Line 2068:         case GSM_HR_BYTES:      /* TCH HR in "pure" form */
case GSM_HR_BYTES_RTP_RFC5993:  /* TCH HR with RFC 5993 prefix */
     tch_data++
     /* fall-through */
case GSM_HR_BYTES:
     ....



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32961
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I13eaad366f9f68615b9e9e4a5f87396a0e9dea0f
Gerrit-Change-Number: 32961
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: falconia <[email protected]>
Gerrit-Comment-Date: Tue, 23 May 2023 15:37:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to