Attention is currently required from: pespin.

falconia has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/32961 )

Change subject: gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 
payloads
......................................................................


Patch Set 2:

(1 comment)

File src/coding/gsm0503_coding.c:

https://gerrit.osmocom.org/c/libosmocore/+/32961/comment/0014945e_1d4d67d7
PS2, Line 2093:
> I find it a bit weird that you are adding spaces here while in the 
> fallthrough case you don't. […]
I see your point - I'll make a new version without those spaces.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32961
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I13eaad366f9f68615b9e9e4a5f87396a0e9dea0f
Gerrit-Change-Number: 32961
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 23 May 2023 16:36:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to