Attention is currently required from: falconia, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/32961 )

Change subject: gsm0503_tch_hr_encode(): accept both TS101318 and RFC5993 
payloads
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

File src/coding/gsm0503_coding.c:

https://gerrit.osmocom.org/c/libosmocore/+/32961/comment/2930de3d_9835b280
PS1, Line 1591:         for (i = 0; i < 112; i++)
> Yes, I am changing the internal static function to take unprefixed 14-byte 
> payloads as input, rather […]
Ack


File src/coding/gsm0503_coding.c:

https://gerrit.osmocom.org/c/libosmocore/+/32961/comment/c71c17d5_db61597a 
PS2, Line 2093:
> I see your point - I'll make a new version without those spaces.
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32961
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I13eaad366f9f68615b9e9e4a5f87396a0e9dea0f
Gerrit-Change-Number: 32961
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: falconia <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 23 May 2023 17:53:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: falconia <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to