Patch Set 4: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/4893/4/src/osmo_ss7.c
File src/osmo_ss7.c:

Line 1792: osmo_ss7_xua_server_create(struct osmo_ss7_instance *inst, enum 
osmo_ss7_asp_protocol proto,
> We don't need changes anywhere else because the only direct user of this AP
I think even simple_server is not used in osmocom projects either, as the only 
server is the STP (SG) while all other entities are clients (ASPs) that connect 
to the STP/SG.


-- 
To view, visit https://gerrit.osmocom.org/4893
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79738963d633bec70705ff159c5b2127cd498aa2
Gerrit-PatchSet: 4
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-HasComments: Yes

Reply via email to