Attention is currently required from: pespin, dexter.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/33571 )

Change subject: MME_Tests: add docker tests for MME
......................................................................


Patch Set 1:

(3 comments)

File debian-bullseye-titan/Dockerfile:

https://gerrit.osmocom.org/c/docker-playground/+/33571/comment/727c0608_f20c9b06
PS1, Line 34:           libgnutls28-dev \
move after inetutils-ping, so the list is still ordered alphabetically


File ttcn3-mme-test-ogs/jenkins.sh:

https://gerrit.osmocom.org/c/docker-playground/+/33571/comment/9d9c9cd1_d115ad9f
PS1, Line 5: KERNEL_TEST="${KERNEL_TEST:-0}"
unused


https://gerrit.osmocom.org/c/docker-playground/+/33571/comment/6a2c223a_c91e7dab
PS1, Line 27: --cap-add=NET_ADMIN \
            :           --device /dev/net/tun:/dev/net/tun \
            :           --sysctl net.ipv6.conf.all.disable_ipv6=0 \
do you need these options, or are they just copied from other Dockerfiles and 
it works fine without them? (but looking at mme.sh they are probably needed)



--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33571
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ic1ce1dace47353b0dcf321c923a78567e3ddefb9
Gerrit-Change-Number: 33571
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Wed, 05 Jul 2023 10:53:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to