Attention is currently required from: osmith, laforge, fixeria, pespin.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/33571 )

Change subject: MME_Tests: add docker tests for MME
......................................................................


Patch Set 2:

(4 comments)

File debian-bullseye-titan/Dockerfile:

https://gerrit.osmocom.org/c/docker-playground/+/33571/comment/ffd8ba65_3a697c88
PS1, Line 34: libgnutls28-dev
> Could you also clarify why this new dependency is needed (in the commit 
> message)? I am guessing the  […]
Done


https://gerrit.osmocom.org/c/docker-playground/+/33571/comment/6e51d518_66592460
PS1, Line 34:           libgnutls28-dev \
> move after inetutils-ping, so the list is still ordered alphabetically
Done


File ttcn3-mme-test-ogs/jenkins.sh:

https://gerrit.osmocom.org/c/docker-playground/+/33571/comment/91862cfc_98c6ec7a
PS1, Line 5: KERNEL_TEST="${KERNEL_TEST:-0}"
> unused
Done


https://gerrit.osmocom.org/c/docker-playground/+/33571/comment/202a32d9_8030fbb9
PS1, Line 27: --cap-add=NET_ADMIN \
            :           --device /dev/net/tun:/dev/net/tun \
            :           --sysctl net.ipv6.conf.all.disable_ipv6=0 \
> The feature is enabled simply to make sure it is used and spot 
> regressions/changes in the feature fo […]
The tun device is definitely not needed. I also dropped the so_bindtodevice. 
There are no changes in the behavior.



--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33571
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ic1ce1dace47353b0dcf321c923a78567e3ddefb9
Gerrit-Change-Number: 33571
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 06 Jul 2023 14:22:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to