Attention is currently required from: fixeria, pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/33753 )
Change subject: gmm: Update DRX params during rx RAU REQ ...................................................................... Patch Set 1: (1 comment) File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/33753/comment/0be65c6a_3c7a2b0a PS1, Line 1770: TLVP_PRESENT > Don't we need to check the length before copying `sizeof(mmctx->drx_parms)` > bytes? TLVP_PRES_LEN could possibly be used. Or the code in libosmocore that defines minimumg length for each IE, as well as permitted/required IEs and which would then be called once before passing any messages further down into various handling functions which then can all rely on the guarantees provided by the shared/common validation. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/33753 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I1dd7f8f161280dd017c337eacc3aa2be4ccd65ea Gerrit-Change-Number: 33753 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Sun, 16 Jul 2023 18:07:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
