Attention is currently required from: laforge, fixeria, dexter.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/33753 )

Change subject: gmm: Update DRX params during rx RAU REQ
......................................................................


Patch Set 1:

(1 comment)

File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/33753/comment/19002205_f7d84a9f
PS1, Line 1770: TLVP_PRESENT
> TLVP_PRES_LEN could possibly be used. […]
I thought that was already tested by tlv_parse?

"""
static const struct tlv_definition gsm48_gmm_att_tlvdef = {
        .def = {
...
                [GSM48_IE_GMM_DRX_PARAM]        = { TLV_TYPE_FIXED, 2 },
...
        },
};
"""



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/33753
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1dd7f8f161280dd017c337eacc3aa2be4ccd65ea
Gerrit-Change-Number: 33753
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Mon, 17 Jul 2023 08:47:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to