Attention is currently required from: pespin, fixeria, dexter.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/33753 )

Change subject: gmm: Update DRX params during rx RAU REQ
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/33753/comment/a038612f_bf332dbd
PS1, Line 1770: TLVP_PRESENT
> I thought that was already tested by tlv_parse? […]
ah, it is a fixed-length element.   Then yes, that shold be guaranteed by 
tlv_parse.  My comments were about fields with variable-length.



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/33753
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1dd7f8f161280dd017c337eacc3aa2be4ccd65ea
Gerrit-Change-Number: 33753
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 18 Jul 2023 06:24:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to