Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/34122 )
Change subject: sgsn_rim: forward message based on RIM ROUTING ADDRESS ...................................................................... Patch Set 2: (3 comments) File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/34122/comment/495fdd7d_9b476d83 PS1, Line 707: if (gtpie_gettlv(ie, GTPIE_RIM_RA_DISCR, 0, &rim_ra_encoded_len, rim_ra_encoded, > can you move thisgtpie_gettlv() call to be "rc = ... […] Done https://gerrit.osmocom.org/c/osmo-sgsn/+/34122/comment/2535c06f_1d1a5ad0 PS1, Line 714: rim_ra_encoded[0] = BSSGP_RIM_ROUTING_INFO_UTRAN; > why are you using an array in here? we have no packed struct explaining what > is this buffer? The problem here is that we deal with two different types, RIM ROUTING ADDRESS and RIM ROUTING INFORMATION. RIM ROUTING INFORMATION is basically RIM ROUTING ADDRESS DISCRIMINATOR (1 byte) + RIM ROUTING ADDRESS - but I see, this is probably not very elegant. We should have a decoder that handles this. https://gerrit.osmocom.org/c/osmo-sgsn/+/34122/comment/a7a022c2_fe65f9df PS1, Line 715: } > rim_ra_encoded++; Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/34122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ifd2b915ed2f05130cff8ee77714b82005c17de3d Gerrit-Change-Number: 34122 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 10 Aug 2023 09:58:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
