Attention is currently required from: pespin, dexter.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/34122 )

Change subject: sgsn_rim: forward message based on RIM ROUTING ADDRESS
......................................................................


Patch Set 3:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-sgsn/+/34122/comment/85999748_3c81504b
PS3, Line 10: corredt
correct


File src/sgsn/sgsn_libgtp.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/34122/comment/0a31d719_5835bc51
PS3, Line 721:          rim_ra_discr = rim_ra_discr_encoded[0];
> I really see no point in having these 2 vars here. […]
unless we're missing something, I'm agreeing with pespin here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/34122
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ifd2b915ed2f05130cff8ee77714b82005c17de3d
Gerrit-Change-Number: 34122
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Mon, 21 Aug 2023 18:43:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to