Attention is currently required from: pespin.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/34122 )

Change subject: sgsn_rim: forward message based on RIM ROUTING ADDRESS
......................................................................


Patch Set 3:

(1 comment)

File src/sgsn/sgsn_libgtp.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/34122/comment/fe234a04_2ee2e559
PS2, Line 706:  uint8_t rim_ra_discr_encoded[1024];
> having 1024 byte buffer for a 1 byte field seems a bit overkill. Same for 
> routing address. […]
Lets use 256 bytes for the RIM ROUTING ADDRESS



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/34122
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ifd2b915ed2f05130cff8ee77714b82005c17de3d
Gerrit-Change-Number: 34122
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 15 Aug 2023 10:23:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to