Attention is currently required from: fixeria.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-gprs/+/34044 )

Change subject: rlcmac: Fix Starting Time rfn->fn calculation
......................................................................


Patch Set 3: -Code-Review

(2 comments)

File src/rlcmac/rlcmac_dec.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/0895ce09_86c82d6c
PS3, Line 434: rfn_to_fn
> May be a good idea to have this function in libosmocore.git 
> (`src/gsm/gsm0502. […]
Ack


File tests/rlcmac/Makefile.am:

https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/c9da486f_12cb7d75
PS3, Line 52: rlcmac_types_test_LDADD = $(LDADD)
> " No newline at end of right file. […]
Ack



--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34044
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I00741289333853a8db472950ee2ac38dc2c74fd3
Gerrit-Change-Number: 34044
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Fri, 11 Aug 2023 18:02:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to