Attention is currently required from: osmith, fixeria.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-gprs/+/34044 )

Change subject: rlcmac: Fix Starting Time rfn->fn calculation
......................................................................


Patch Set 4:

(1 comment)

File tests/rlcmac/rlcmac_types_test.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/a03c1bdb_f496d619
PS3, Line 54: printf
> agreed
This allows easily separating internal logging from test specific logging. If 
we want we can always change it to print both to the same file in autotest 
iirc, but I see no need here since it's a rather small test.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34044
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I00741289333853a8db472950ee2ac38dc2c74fd3
Gerrit-Change-Number: 34044
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 21 Aug 2023 11:05:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to