Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email )
Change subject: Implement M3UA-over-TCP (in addition to SCTP) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > > I wonder whether we really want to add/maintain a > > "OSMO_SS7_ASP_PROT_M3UA_TCP" type ... […] Well, tbh I also wonder whether we should be adding a new "m3ua-tcp" type. I think you are just mixing protocol layers there. When you configure it as M3UA, everything should work the same at M3UA level. It's only a detail on which protocol you use beneath it. So it probably makes sense to keep "m3ua" in vty for both, and add some extra option "transport (sctp|tcp)" which defaults to sctp. In the end is lower layer details like whether the transport acts as a server or as a client. And we don't have "m3ua-client" or "m3ua-server". -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d Gerrit-Change-Number: 35796 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Sat, 03 Feb 2024 17:28:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
