Attention is currently required from: jolly, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email )
Change subject: Implement M3UA-over-TCP (in addition to SCTP) ...................................................................... Patch Set 5: (2 comments) File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/c98135b5_c87c5106 PS4, Line 515: int osmo_ss7_asp_get_trans_proto(const struct osmo_ss7_asp *asp); > Is this needed by any app right now? No. But this does not mean that we should not be adding it. It complements the existing `osmo_ss7_asp_get_proto()`. I would keep it, unless you're totally against it. https://gerrit.osmocom.org/c/libosmo-sccp/+/35796/comment/f5c7c2c7_c89902c9 PS4, Line 566: int trans_proto; > You need to update TODO-RELEASE about new fields and APIs. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d Gerrit-Change-Number: 35796 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: jolly <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 15 Feb 2024 22:49:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
