Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email )
Change subject: Implement M3UA-over-TCP (in addition to SCTP) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I agree that conceptually it is "mixing layers". […] To me its clear given the combination matrix above that it makes no sense to create a type for each of those permutations. Futhermore, following the same rule of thumb we'd also have yet another axis where one would have "tcp-client" and another "tcp-server", and "sctp-client", and "sctp-server". All of that makes no sense, it's clearly trying to put together stuff from different layers, which we already keep properly separated by the "role asp|sg" and "sctp-role client|server". I'd really go for adding a "transport tcp|sctp" and be done with. Most of the code can be kept the same and we only need to patch sections really doing stuff with lower layers. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d Gerrit-Change-Number: 35796 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: jolly <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Fri, 09 Feb 2024 13:01:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
