Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email )
Change subject: asterisk: Implement AMI_Adapter using IPL4 instead of TELNET ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/91813d64_50443eeb PS2, Line 26: ": " token in the value. I'd expect TEXT decoder to put all subsequent > pleas do make sure to report each of those to the eclipse TITAN forum. […] Ack, Vadim is going to give a look at those and we'll end up probably reporting them. But I wanted first to focus on getting a bit more through the test infrastructures with all the events being parsed and tests passing. File asterisk/AMI_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/5fd92a3e_d676f2a3 PS2, Line 189: welcome_str := "Asterisk Call Manager/9.0.0\r\n" > wouldn't this better be a regex? so that code could match multiple different > versions, or ignore ver […] Yes I already though about this possiblity, it can probably be done but I'm so far focusing on getting the whole thing working together. I think we can fix and improve small parts like this afterwards. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icaf2860c1dd4befa4498f0d176cfadf26cfa8d1d Gerrit-Change-Number: 36755 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Thu, 09 May 2024 12:38:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
