Attention is currently required from: osmith.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email )

Change subject: asterisk: Implement AMI_Adapter using IPL4 instead of TELNET
......................................................................


Patch Set 3:

(1 comment)

File asterisk/AMI_Functions.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/e98ef540_60d244c4
PS3, Line 480:  log("AMI_Msg decoded: ", msg);
> add some sort of assert / check at the end, that the decode lead to the 
> expected result?
That's more like a playground to test stuff interactively (recompile, test, 
etc.) not something really being run during usual testsuite.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icaf2860c1dd4befa4498f0d176cfadf26cfa8d1d
Gerrit-Change-Number: 36755
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Fri, 10 May 2024 12:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>
Gerrit-MessageType: comment

Reply via email to