Attention is currently required from: pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email )

Change subject: asterisk: Implement AMI_Adapter using IPL4 instead of TELNET
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/e429682c_d4c8b466
PS2, Line 26: ": " token in the value. I'd expect TEXT decoder to put all 
subsequent
> Ack, Vadim is going to give a look at those and we'll end up probably 
> reporting them. […]
Done


File asterisk/AMI_Functions.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/c40b125d_1792b233
PS2, Line 189:  welcome_str := "Asterisk Call Manager/9.0.0\r\n"
> I'd even have to look at how is this line supposed to be changed over time, 
> and support different ve […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icaf2860c1dd4befa4498f0d176cfadf26cfa8d1d
Gerrit-Change-Number: 36755
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 09 May 2024 15:20:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to