Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37848?usp=email )
Change subject: pySim.esim.saip: maintain a parsed fileystem hierarchy ...................................................................... Patch Set 1: (2 comments) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/37848/comment/3def40f0_c6efb131?usp=email : PS1, Line 100: def __init__(self, pename: str, l: Optional[List[Tuple]] = None, template: : Not really related to this patch, but looks like you want to use `**kwargs` here to pass optional parameters. Also, you're missing to add a docstring for the new `name` param. https://gerrit.osmocom.org/c/pysim/+/37848/comment/42c781f6_2fe4ea56?usp=email : PS1, Line 139: if False: Intentional? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2caadc24b1087855f23f3c57cdf8dabbf81757c0 Gerrit-Change-Number: 37848 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Sun, 18 Aug 2024 06:06:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
