Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37848?usp=email )
Change subject: pySim.esim.saip: maintain a parsed fileystem hierarchy ...................................................................... Patch Set 4: (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/37848/comment/31679e21_358f4fef?usp=email : PS1, Line 100: def __init__(self, pename: str, l: Optional[List[Tuple]] = None, template: : > I don't get the **kwargs argument, but I've added the name docstring. I meant making the constructor accept `**kw` rather than adding even more `Optional` parameters: ``` def __init__(self, pename: str, **kw): self.foo: FooType = kw.get('foo') self.bar: BarType = kw.get('bar') if 'l' in kw: self.from_tuples(kw['l']) ``` This way the method declaration is more readable. This is a usual practice in Python. Not critical. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2caadc24b1087855f23f3c57cdf8dabbf81757c0 Gerrit-Change-Number: 37848 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Sun, 18 Aug 2024 13:37:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
