Attention is currently required from: fixeria.

laforge has posted comments on this change by laforge. ( 
https://gerrit.osmocom.org/c/pysim/+/37848?usp=email )

Change subject: pySim.esim.saip: maintain a parsed fileystem hierarchy
......................................................................


Patch Set 4:

(1 comment)

File pySim/esim/saip/__init__.py:

https://gerrit.osmocom.org/c/pysim/+/37848/comment/c945018f_bd760c24?usp=email :
PS1, Line 100:     def __init__(self, pename: str, l: Optional[List[Tuple]] = 
None, template:
             :
> Not really related to this patch, but looks like you want to use `**kwargs` 
> here to pass optional pa […]
I don't get the **kwargs argument, but I've added the name docstring.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37848?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2caadc24b1087855f23f3c57cdf8dabbf81757c0
Gerrit-Change-Number: 37848
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Sun, 18 Aug 2024 13:27:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to