Attention is currently required from: daniel, pespin. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email )
Change subject: add routing areas ...................................................................... Patch Set 3: (11 comments) File include/osmocom/sgsn/gprs_routing_area.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/c1993493_cd188347?usp=email : PS3, Line 70: int sgsn_ra_foreach_cell(struct sgsn_ra *ra, sgsn_ra_cb_t *cb, void *cb_data); space required before the open parenthesis '(' File src/sgsn/gprs_routing_area.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/4ccf8484_799e9b0b?usp=email : PS3, Line 30: llist_for_each_entry_safe(cell, cell2, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/ad441ece_74622079?usp=email : PS3, Line 95: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/34a39a6c_85abbe17?usp=email : PS3, Line 111: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/541ba466_ea908351?usp=email : PS3, Line 112: llist_for_each_entry(cell, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/5f726bab_c1e0d3f5?usp=email : PS3, Line 124: int sgsn_ra_foreach_cell(struct sgsn_ra *ra, sgsn_ra_cb_t *cb, void *cb_data) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/9ce6bc67_a1ff6478?usp=email : PS3, Line 131: llist_for_each_entry_safe(cell, tmp, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/aaaff72e_f3925af8?usp=email : PS3, Line 157: return sgsn_ra_foreach_cell(ra, cb, cb_data); space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/c2b3ea9f_f02825d3?usp=email : PS3, Line 164: llist_for_each_entry(cell, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/068e235f_2183b2e3?usp=email : PS3, Line 179: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/3b56f7b7_c791067a?usp=email : PS3, Line 183: llist_for_each_entry(cell, &ra->cells, list) { space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa Gerrit-Change-Number: 37864 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Tue, 20 Aug 2024 15:18:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
