Attention is currently required from: daniel, lynxis lazus, pespin. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email )
Change subject: add routing areas ...................................................................... Patch Set 5: (11 comments) File include/osmocom/sgsn/gprs_routing_area.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/19728574_13a4d5e3?usp=email : PS5, Line 70: int sgsn_ra_foreach_cell(struct sgsn_ra *ra, sgsn_ra_cb_t *cb, void *cb_data); space required before the open parenthesis '(' File src/sgsn/gprs_routing_area.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/7eada1b7_0e584088?usp=email : PS5, Line 30: llist_for_each_entry_safe(cell, cell2, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/5e317014_748efbf5?usp=email : PS5, Line 95: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/3e617727_c59cbc46?usp=email : PS5, Line 111: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/c3fc6454_a4d14037?usp=email : PS5, Line 112: llist_for_each_entry(cell, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/af7e213b_2a18ecf6?usp=email : PS5, Line 124: int sgsn_ra_foreach_cell(struct sgsn_ra *ra, sgsn_ra_cb_t *cb, void *cb_data) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/bfa3f0a8_73c4aff2?usp=email : PS5, Line 131: llist_for_each_entry_safe(cell, tmp, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/256f387c_cfaaf312?usp=email : PS5, Line 157: return sgsn_ra_foreach_cell(ra, cb, cb_data); space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/85f968aa_356b4a5c?usp=email : PS5, Line 164: llist_for_each_entry(cell, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/2befa7be_7f8313db?usp=email : PS5, Line 179: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/9cdb9be8_010f094d?usp=email : PS5, Line 183: llist_for_each_entry(cell, &ra->cells, list) { space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa Gerrit-Change-Number: 37864 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Tue, 20 Aug 2024 15:39:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
