Attention is currently required from: fixeria.

pespin has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696?usp=email )

Change subject: bts: add TC_data_facch_*: test FACCH/[FH] on data channels
......................................................................


Patch Set 3:

(3 comments)

File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/dae79ff2_e2ff23fa?usp=email
 :
PS3, Line 9552:         /* TODO: execute( TC_data_facch_tchh48() ); */
maybe write down in the comment that it crashes osmo-bts. Is there a related 
osmocom ticket? maybe also put it there.


File bts/expected-results.xml:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/d4e11997_da965f05?usp=email
 :
PS3, Line 2: <testsuite name='Titan' tests='242' failures='5' errors='0' 
skipped='0' inconc='0' time='MASKED'>
missing increment here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/9f95c2d4_486c9a92?usp=email
 :
PS3, Line 205:   <testcase classname='BTS_Tests' name='TC_data_facch_tchh48' 
time='MASKED'/>
but we are not running this yet right? so it shouldn't appear here, and it 
shouldn't for sure be as passed, since it crashes the bts?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2098ccd651fc2a81f62e70be64af386ab0ca6148
Gerrit-Change-Number: 38696
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Fri, 08 Nov 2024 12:59:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to