Attention is currently required from: fixeria, osmith.

pespin has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696?usp=email )

Change subject: bts: add TC_data_facch_*: test FACCH/[FH] on data channels
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/aaaf2dbd_62559d4a?usp=email
 :
PS3, Line 9552:         /* TODO: execute( TC_data_facch_tchh48() ); */
> I have fixed the problem meanwhile: […]
This is going to crash osmo-bts in lastest though? then add a guard against 
crashing with " if (Misc_Helpers.f_osmo_repo_is("nightly")) {"



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2098ccd651fc2a81f62e70be64af386ab0ca6148
Gerrit-Change-Number: 38696
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Fri, 08 Nov 2024 15:45:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to