Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696?usp=email )
Change subject: bts: add TC_data_facch_*: test FACCH/[FH] on data channels ...................................................................... Patch Set 4: (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696/comment/174536c0_a588758e?usp=email : PS3, Line 9552: /* TODO: execute( TC_data_facch_tchh48() ); */ > This is going to crash osmo-bts in lastest though? then add a guard against > crashing with " if (Misc […] No, it's not going to crash -latest nor -master because "we call f_rtpem_activate(), which does CRCX/MDCX" in late revisions of this patch. I also fixed the problem in -master (https://gerrit.osmocom.org/c/osmo-bts/+/38697) to avoid sporadic crashes in real setups. So all in all we have two points of confidence that it's safe ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38696?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2098ccd651fc2a81f62e70be64af386ab0ca6148 Gerrit-Change-Number: 38696 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2024 16:18:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
