Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email )
Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... Patch Set 6: (3 comments) File include/osmocom/ranap/iu_client.h: https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/33722f00_122646f1?usp=email : PS6, Line 70: OSMO_DEPRECATED("Use ranap_iu_page_cs2 instead."); > I think we don't actually put dots at the end here usually. Done File include/osmocom/ranap/iu_client.h: https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/bdac889c_9a9a7ba7?usp=email : PS3, Line 68: int ranap_iu_page_cs(const char *imsi, const uint32_t *tmsi, uint16_t lac); > btw, we probably want to mark these as DEPRECATED in this same patch. Done File src/iu_client.c: https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/5a5775d7_9756d521?usp=email : PS3, Line 901: }; > yes, you're right for CS Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 14 Jan 2025 17:03:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]>
