Attention is currently required from: daniel, neels, pespin.
laforge has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-netif/+/39316?usp=email )
Change subject: stream: Introduce osmo_stream_{cli,srv}_set_segmentation_cb2
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I am wondering if there's another alternative that we can do this without
introducing the clumsy *2() API workaround... like passing the data via
msgb->cb? or maybe even better msg->dst? If it's an optional feature that the
calling application can enable via some
osmo_stram_srv_enable_segmentation_callback_dst() or the like, then we also
have no risk of overwriting msgb fileds that are actually in use.
But even that is unlikely. I would argue in the segmentation_cb none of those
msgb fields are used for anything yet, as the msgb hasn't even been officially
passed into the application yet.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39316?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I6e8dd6ece13397074075f05a1a0a8dbdd80d8848
Gerrit-Change-Number: 39316
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Thu, 16 Jan 2025 11:21:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
