Attention is currently required from: daniel, laforge, neels.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-netif/+/39316?usp=email )
Change subject: stream: Introduce osmo_stream_{cli,srv}_set_segmentation_cb2
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> @laforge@osmocom. […]
BTW, we cannot simply drop osmo_stream_*segmentation_cb() because it was
already added in f990b307bdc2c2f7dc94256094d3b60917d37177 and included in
release 1.4.0, hence available in 1.4.0, 1.5.0 and 1.5.1.
So yes, I think it's not ideal but imho the proposal here is the best, with the
aim to convert existing users (libosmo-sigtram, osmo-remsim, osmo-bsc,
libosmo-abis) to this new API and eventually in the future remove the old one.
Most of the users above are actually using the segmentation_cb() since a few
weeks ago when I moved the ipaccess code to use osmo_stream, so we can change
those quickly and then I think almost nobody will be using a segmentation_cb(1)
in a release.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39316?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I6e8dd6ece13397074075f05a1a0a8dbdd80d8848
Gerrit-Change-Number: 39316
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Thu, 16 Jan 2025 15:03:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
