Attention is currently required from: fixeria, pespin.

laforge has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email )

Change subject: enft_kpi: retrieve per-eNB traffic counters
......................................................................


Patch Set 8: Code-Review+1

(2 comments)

File config/sys.config:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/5a1ffaa3_46b7d111?usp=email
 :
PS8, Line 24: %% {enft_kpi_enable, true}, %% whether to enable the NFT KPI 
module (default: false)
> "nft" is a well known and established system-wide component, which users can 
> easily understand from  […]
I tend to agree with pespin, and probably even more with Vadims's suggestion to 
call it gtpu_ as the user doesn't care about the implementation.


File rebar.config:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/2cd57114_df99f45a?usp=email
 :
PS8, Line 13:          {git, 
"https://gitea.osmocom.org/vyanitskiy/enftables.git";, {branch, 
"fixeria/json"}}},
> > Again, I'll move the library to https://gitea.osmocom. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I498d2854447a2d53d2abddd38652f3e2bbb1fbdd
Gerrit-Change-Number: 40281
Gerrit-PatchSet: 8
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 28 May 2025 14:05:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to