Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email )
Change subject: enft_kpi: retrieve per-eNB traffic counters ...................................................................... Patch Set 10: (4 comments) File include/s1gw_metrics.hrl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/d6a352e4_f6ec44a2?usp=email : PS8, Line 40: %% NOTE: these counters shall not be listed in ?S1GW_COUNTERS, > It's fine having a comment, just though the comment there kind of created an > alamr in my head (as in […] Done File rebar.config: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/46d0aa01_270946c3?usp=email : PS8, Line 13: {git, "https://gitea.osmocom.org/vyanitskiy/enftables.git";, {branch, "fixeria/json"}}}, > Done https://gitea.osmocom.org/erlang/enftables File src/enft_kpi.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/82f7c362_5230c1ad?usp=email : PS8, Line 142: R1 = [nft_expr_match_ip_proto("udp", ?OP_NEQ), nft_expr_accept()], > Acknowledged https://gitea.osmocom.org/erlang/enftables/commit/63b0d9ebc2db8bda72bce8a9baf82ef938304a58 https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40439 https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/51b58590_b461812c?usp=email : PS8, Line 341: case enb_add_nft_counters(ES0#{addr => Addr}, Cfg) of > Be careful though because that may need some work/complexity as it becomes > async. […] Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I498d2854447a2d53d2abddd38652f3e2bbb1fbdd Gerrit-Change-Number: 40281 Gerrit-PatchSet: 10 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 05 Jun 2025 11:24:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
