Attention is currently required from: fixeria, laforge.

pespin has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email )

Change subject: enft_kpi: retrieve per-eNB traffic counters
......................................................................


Patch Set 8:

(1 comment)

File config/sys.config:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281/comment/c537fa4a_fe382e55?usp=email
 :
PS8, Line 24: %% {enft_kpi_enable, true}, %% whether to enable the NFT KPI 
module (default: false)
> I tend to agree with pespin, and probably even more with Vadims's suggestion 
> to call it gtpu_ as the […]
Ack, but then enft_kpi_table_name may well become "gtpu_kpi_nft_table_name", 
otherwise one doesn't really know what the "table" is about...



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40281?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I498d2854447a2d53d2abddd38652f3e2bbb1fbdd
Gerrit-Change-Number: 40281
Gerrit-PatchSet: 8
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 28 May 2025 14:08:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to