Attention is currently required from: dexter, neels.

laforge has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/42043?usp=email )

Change subject: esim/http_json_api: add alternative API interface
......................................................................


Patch Set 4:

(3 comments)

Patchset:

PS4:
looks fine to me, except the print statements.


File pySim/esim/http_json_api.py:

https://gerrit.osmocom.org/c/pysim/+/42043/comment/090284ee_c20b95bc?usp=email :
PS4, Line 237:
I think you probably wanted to remove those print statements before submitting 
it here? ;)


https://gerrit.osmocom.org/c/pysim/+/42043/comment/e88d4c63_8452cb4a?usp=email :
PS4, Line 272:
not sure we want those all the time from sysmo-esim-mgr. I expect every API 
call would trigger one, right?



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42043?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2a5d4b59b12e08d5eae7a1215814d3a69c8921f6
Gerrit-Change-Number: 42043
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Wed, 04 Feb 2026 13:44:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to