Attention is currently required from: dexter. neels has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42043?usp=email )
Change subject: esim/http_json_api: add alternative API interface ...................................................................... Patch Set 6: (2 comments) Patchset: PS6: I would vote for a simpler approach, without needing to interfere with class instantiation: choose a different class name for the new client, leave the "legacy" class as-is, except, if needed, moving some bits to a new base class that old and new implementations can inherit from. IMHO that should be far easier to read and maintain. File pySim/esim/http_json_api.py: https://gerrit.osmocom.org/c/pysim/+/42043/comment/7f2a94a1_dc29af89?usp=email : PS6, Line 224: cls_attr = { attr_name: getattr(cls, attr_name) for attr_name in dir(cls) if not match("__.*__", attr_name) } if not attr_name.startswith('__') -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2a5d4b59b12e08d5eae7a1215814d3a69c8921f6 Gerrit-Change-Number: 42043 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Mon, 09 Feb 2026 14:32:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
