Attention is currently required from: dexter.

neels has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/42043?usp=email )

Change subject: esim/http_json_api: add alternative API interface
......................................................................


Patch Set 6:

(2 comments)

File pySim/esim/http_json_api.py:

https://gerrit.osmocom.org/c/pysim/+/42043/comment/a9c9283c_9c9756e5?usp=email :
PS6, Line 227:         if len(args) == 0:
ignores len(kwargs)
(any arg could also be passed as kwarg)


https://gerrit.osmocom.org/c/pysim/+/42043/comment/5dce0c51_2c01ee29?usp=email :
PS6, Line 231:         role = kwargs.get('role', 'legacy_client')
role will always be 'legacy_client' bc the role arg is not part of kwargs



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42043?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2a5d4b59b12e08d5eae7a1215814d3a69c8921f6
Gerrit-Change-Number: 42043
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Mon, 09 Feb 2026 13:52:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to