Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email )
Change subject: Fix lint errors: don't use star imports ...................................................................... Patch Set 2: (1 comment) File tests/test_construct.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/41384/comment/7ba59e6b_487c8ca5?usp=email : PS2, Line 8: DnsAdapter, > @laforge@osmocom. […] The usual approach in our code would be to simply have two (or more) lines starting with "from osmocom.construct import ...". See https://gitea.osmocom.org/osmocom/pyosmocom/src/commit/a5bc2a20f439f2ab309a38bfa6e2cf4266e9c11a/src/osmocom/construct.py#L14 for example, where we have three lines doing "from construct import ..." I often even group the imported symbols logically in such situations. I personally think one line per symbol is wasteful of my screen real-esetate. If there's a standard to do it differently, but then we should convert the entire codebase to that style, and not do it one way in one file and another way in another file. PEP8 doesn't seem to cover that situation, at least I couldn't find it in my reading of the "Imports" section. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0ca76a40d47f72635682de9303ff73e9b2197266 Gerrit-Change-Number: 41384 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2026 16:31:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Comment-In-Reply-To: laforge <[email protected]>
